Fix private-in-public error in rustc before 1.74.0 #3675
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Rustc 1.74.0 removed the private-in-public check, which raises a compile-time error if a member of a struct has a type which is less visible than the parent struct. Fixing this private-in-public issue enables aws-smithy-runtime to build in projects using rustc older than 1.74.0.
Description
Make UploadThroughputCheckFuture pub(crate) because it is needed in MaybeUploadThroughputCheckFuture which is pub(crate).
Testing
Verified that crate now compiles using rustc 1.72.1.
Checklist
CHANGELOG.next.toml
if I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.toml
if I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.