Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix private-in-public error in rustc before 1.74.0 #3675

Merged
merged 5 commits into from
Jun 4, 2024

Conversation

nerdile
Copy link
Contributor

@nerdile nerdile commented May 31, 2024

Motivation and Context

Rustc 1.74.0 removed the private-in-public check, which raises a compile-time error if a member of a struct has a type which is less visible than the parent struct. Fixing this private-in-public issue enables aws-smithy-runtime to build in projects using rustc older than 1.74.0.

Description

Make UploadThroughputCheckFuture pub(crate) because it is needed in MaybeUploadThroughputCheckFuture which is pub(crate).

Testing

Verified that crate now compiles using rustc 1.72.1.

Checklist

  • I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates
  • I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@nerdile nerdile requested a review from a team as a code owner May 31, 2024 19:15
@nerdile nerdile requested a review from a team as a code owner May 31, 2024 19:17
Copy link
Contributor

@ysaito1001 ysaito1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we probably just need to bump a patch version of aws-smithy-runtime in its Cargo.toml

@nerdile
Copy link
Contributor Author

nerdile commented May 31, 2024

@rcoh :

  • PR bot and canary cannot be invoked from a forked repository. Ask a maintainer to manually invoke them using your PR.
  • check-sdk-codegen-unit-tests failing to find recently published tokio-macros crate
    Anything I can do to resolve these?

@nerdile
Copy link
Contributor Author

nerdile commented May 31, 2024

LGTM, we probably just need to bump a patch version of aws-smithy-runtime in its Cargo.toml

Thanks @ysaito1001 , is this something I should address or will the team take care of it?

@ysaito1001
Copy link
Contributor

ysaito1001 commented May 31, 2024

We'll handle the rest and get it merged because the rest is a small chore. Thanks for the PR!

Passed canary run

@ysaito1001 ysaito1001 enabled auto-merge June 4, 2024 17:47
@ysaito1001 ysaito1001 added this pull request to the merge queue Jun 4, 2024
Merged via the queue into smithy-lang:main with commit fe6bb7c Jun 4, 2024
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants