Fix AwsQuery target serialization #3210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Velfi
reviewed
Nov 16, 2023
| @@ -137,6 +141,7 @@ fun Project.registerGenerateSmithyBuildTask( | |||
| this.tasks.register("generateSmithyBuild") { | |||
| description = "generate smithy-build.json" | |||
| outputs.file(project.projectDir.resolve("smithy-build.json")) | |||
| // NOTE: This is not working. | |||
There was a problem hiding this comment.
Should we create a TODO + issue for this?
Velfi
approved these changes
Nov 16, 2023
ysaito1001
reviewed
Nov 16, 2023
| message = "Fix broken serialization for SQS" | ||
| references = ["smithy-rs#3210", "aws-sdk-rust#957"] | ||
| meta = { "breaking" = false, "tada" = false, "bug" = false } |
There was a problem hiding this comment.
Ah, this was actually "bug" = true
ysaito1001
added a commit
to awslabs/aws-sdk-rust
that referenced
this pull request
Nov 17, 2023
~~**Draft till internal deployment succeeds. Consider merging this before tomorrow's release.**~~ ## Motivation and Context There was one changelog entry from smithy-lang/smithy-rs#3210 that was missed for `release-2023-11-16`. This PR will fix it. ---- By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.