Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-export ByteStream's Length and FsBuilder in client crates #3796

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

ysaito1001
Copy link
Contributor

@ysaito1001 ysaito1001 commented Aug 19, 2024

Motivation and Context

awslabs/aws-sdk-rust#820

Description

This PR re-exports ByteStream's Length and FsBuilder. By making these types available in a client crate, customers can use ByteStream::read_from without needing to import them separately from the aws-smithy-types crate.

Testing

  • Updated an existing re-export test to include Length and FsBuilder as well.
  • Existing tests in CI

Checklist

  • For changes to the smithy-rs codegen or runtime crates, I have created a changelog entry Markdown file in the .changelog directory, specifying "client," "server," or both in the applies_to key.
  • For changes to the AWS SDK, generated SDK code, or SDK runtime crates, I have created a changelog entry Markdown file in the .changelog directory, specifying "aws-sdk-rust" in the applies_to key.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

Copy link

@ysaito1001 ysaito1001 marked this pull request as ready for review August 19, 2024 22:03
@ysaito1001 ysaito1001 requested review from a team as code owners August 19, 2024 22:03
Copy link
Contributor

@landonxjames landonxjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ysaito1001 ysaito1001 added this pull request to the merge queue Aug 20, 2024
Merged via the queue into main with commit 8ccd2da Aug 20, 2024
44 checks passed
@ysaito1001 ysaito1001 deleted the ysaito/reexport-length-and-fs-builder branch August 20, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants