Add feature ID for S3 Transfer Manager #3921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Velfi
reviewed
Nov 26, 2024
Velfi
reviewed
Nov 26, 2024
Velfi
approved these changes
Nov 26, 2024
Co-authored-by: Zelda Hessler <zhessler@amazon.com>
This commit addresses #3921 (comment)
landonxjames
approved these changes
Nov 26, 2024
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR introduces the
AwsSdkFeatureenum, which will be used for AWS SDK-specific feature identifiers. For now, it includes a single ID for the S3 Transfer Manager. This approach is similar to the existing SmithySdkFeature in terms of its module and crate structure (that is for generic client butAwsSdkFeatureis AWS specific); thesdk_featuremodule is hidden as it is intended for internal use only.Testing
Added an integration test to verify tracking a business metric for Transfer Manager. Since Transfer Manager is a high-level library, we do not track its business metric directly within the
smithy-rsrepository. Instead, an s3 client used in aws-s3-transfer-manager-rs can configure the s3 client as demonstrated in the integration test to track the metric.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.