Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue calling Child.output() on ubuntu-latest with v1.8.0 #55

Closed
ghost opened this issue Sep 30, 2023 · 3 comments · Fixed by #56
Closed

Issue calling Child.output() on ubuntu-latest with v1.8.0 #55

ghost opened this issue Sep 30, 2023 · 3 comments · Fixed by #56

Comments

@ghost
Copy link

ghost commented Sep 30, 2023

Description

We encountered an unexpected problem when using async-process on the ubuntu-latest environment in our CI workflow after it was updated to version v1.8.0 on September 25th.

The issue manifests as erratic behaviour in our code, primarily blocking, when we make calls to Child.output(). We would appreciate any assistance in troubleshooting and resolving it. If you need any further information or logs, please let us know.

Associated Issue: near/near-workspaces-rs#312

@taiki-e
Copy link
Collaborator

taiki-e commented Sep 30, 2023

Thanks for the report, and sorry for the breakage! I've yanked 1.8.0.

cc @notgull

@notgull
Copy link
Member

notgull commented Sep 30, 2023

This might be the same issue as I've encountered in #54. It looks like it's missing the SIGCHLD signal somehow; not sure if this is an issue with async-signal or the new architecture. I'll find a minimal repro of this issue.

notgull added a commit to smol-rs/async-signal that referenced this issue Sep 30, 2023
This backend appears to miss some signals that are raised on other
threads. This might be the cause of smol-rs/async-process#55.

I don't feel like kneading signalfd into a better shape, and it probably
isn't much of an improvement over the pipe strategy anyways. So I've just
removed it.

Signed-off-by: John Nunley <dev@notgull.net>
notgull added a commit to smol-rs/async-signal that referenced this issue Oct 2, 2023
This backend appears to miss some signals that are raised on other
threads. This might be the cause of smol-rs/async-process#55.

I don't feel like kneading signalfd into a better shape, and it probably
isn't much of an improvement over the pipe strategy anyways. So I've just
removed it.

Signed-off-by: John Nunley <dev@notgull.net>
@notgull
Copy link
Member

notgull commented Oct 3, 2023

@shariffdev Can you re-run the tests with the latest master? I believe that smol-rs/async-signal#20 fixed this issue.

notgull added a commit that referenced this issue Oct 6, 2023
Extracted from #54, should fix #55

Signed-off-by: John Nunley <dev@notgull.net>
notgull added a commit that referenced this issue Oct 6, 2023
Extracted from #54, should fix #55

Signed-off-by: John Nunley <dev@notgull.net>
@taiki-e taiki-e mentioned this issue Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants