Remove the signalfd backend #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests make sure the signal handler functions as intended. Signed-off-by: John Nunley <dev@notgull.net>
This backend appears to miss some signals that are raised on other threads. This might be the cause of smol-rs/async-process#55. I don't feel like kneading signalfd into a better shape, and it probably isn't much of an improvement over the pipe strategy anyways. So I've just removed it. Signed-off-by: John Nunley <dev@notgull.net>
taiki-e
reviewed
Oct 1, 2023
.github/workflows/ci.yml
Outdated
| RUSTFLAGS: --cfg async_signal_force_pipe_impl | ||
| if: > | ||
| !contains(matrix.os, 'windows') | ||
| # Windows returns 1 regardless of whether or not the signal is intercepted. |
There was a problem hiding this comment.
Is this due to the behavior described here?
There was a problem hiding this comment.
Yes, I believe it is. Though the Windows backend is currently broken for other reasons.
Signed-off-by: John Nunley <dev@notgull.net> Fix Windows test Signed-off-by: John Nunley <dev@notgull.net> Fix invalid YAML Signed-off-by: John Nunley <dev@notgull.net> Is tee broken? Signed-off-by: John Nunley <dev@notgull.net> Disable Windows in CI
It's still used in signal-hook-registry, but if that crate ever switches to a libc-free strategy we'll be ready. Signed-off-by: John Nunley <dev@notgull.net>
taiki-e
approved these changes
Oct 2, 2023
This was referenced Oct 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backend appears to miss some signals that are raised on other
threads. This might be the cause of smol-rs/async-process#55.
I don't feel like kneading signalfd into a better shape, and it probably
isn't much of an improvement over the pipe strategy anyways. So I've just
removed it.
In addition, this PR also adds tests and removes the libc direct dependency.