Skip to content

Commit

Permalink
Set ui.virtual.ruler background for GitHub themes (helix-editor#9487)
Browse files Browse the repository at this point in the history
Turning on a ruler does not show a visible ruler
line for the GitHub themes. This change renders
rulers using the `canvas.subtle` color. This
matches the color used for the `cursorline` and
creates a visible ruler that fits the theme.
  • Loading branch information
ascarter authored and Schuyler Mortimer committed Jul 10, 2024
1 parent a36f21f commit a60bfef
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions runtime/themes/github_dark.toml
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ label = "scale.red.3"
"ui.text.focus" = { fg = "fg.default" }
"ui.text.inactive" = "fg.subtle"
"ui.virtual" = { fg = "scale.gray.6" }
"ui.virtual.ruler" = { bg = "canvas.subtle" }

"ui.selection" = { bg = "scale.blue.8" }
"ui.selection.primary" = { bg = "scale.blue.7" }
Expand Down
1 change: 1 addition & 0 deletions runtime/themes/github_light.toml
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ label = "scale.red.5"
"ui.text.focus" = { fg = "fg.default" }
"ui.text.inactive" = "fg.subtle"
"ui.virtual" = { fg = "scale.gray.2" }
"ui.virtual.ruler" = { bg = "canvas.subtle" }

"ui.selection" = { bg = "scale.blue.0" }
"ui.selection.primary" = { bg = "scale.blue.1" }
Expand Down

0 comments on commit a60bfef

Please sign in to comment.