Improve diacritics normalization function (removing accents) #1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imbrish
changed the title
caseyjhol
added a commit
that referenced
this pull request
Oct 17, 2018
|
A more advanced normalizeToBase function will be used in the next release. |
|
Released in v1.13.4! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to a few other people I encountered problems when searching through a list that contained strings with diacritics. Other issues: #1551 #1587 #767.
Solved my problem using function from http://jsperf.com/diacritics/27 and decided to share the solution.
Code is a little messy with the long mapping of characters. It probably could be simplified, but according to the benchmark from the link above this is the fastest method. However I haven't tested performance against the old function.