Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build the sticker creator for inclusion in the app #254

Merged
merged 1 commit into from
Jan 9, 2024
Merged

fix: build the sticker creator for inclusion in the app #254

merged 1 commit into from
Jan 9, 2024

Conversation

jnsgruk
Copy link
Member

@jnsgruk jnsgruk commented Jan 9, 2024

Fixes #253

This change ensures that we actually build the sticker-creator part of the app, and prevents a crash when it's used.

@jnsgruk
Copy link
Member Author

jnsgruk commented Jan 9, 2024

I believe this fixes it! Tested locally in a jammy VM under LXD:

image

@jnsgruk jnsgruk marked this pull request as ready for review January 9, 2024 10:39
@jnsgruk jnsgruk requested a review from popey January 9, 2024 10:39
Copy link
Contributor

@popey popey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@merlijn-sebrechts merlijn-sebrechts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@merlijn-sebrechts merlijn-sebrechts merged commit 72b2212 into snapcrafters:candidate Jan 9, 2024
1 check passed
@jnsgruk jnsgruk deleted the sticker-creator branch July 3, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Create/upload Sticker Pack menu option causes a crash
3 participants