Skip to content

Commit ba9fa4b

Browse files
authored
[OSS] Allow overriding createCatalog calls in integrations tests (apache#109)
1 parent 5011b3f commit ba9fa4b

File tree

3 files changed

+18
-2
lines changed

3 files changed

+18
-2
lines changed

integration-tests/src/main/java/org/apache/polaris/service/it/env/ManagementApi.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,10 @@ public GrantResources listGrants(String catalogName, String catalogRoleName) {
150150

151151
public void createCatalog(String principalRoleName, Catalog catalog) {
152152
createCatalog(catalog);
153+
makeAdmin(principalRoleName, catalog);
154+
}
153155

156+
public void makeAdmin(String principalRoleName, Catalog catalog) {
154157
// Create a new CatalogRole that has CATALOG_MANAGE_CONTENT and CATALOG_MANAGE_ACCESS
155158
String catalogRoleName = "custom-admin";
156159
createCatalogRole(catalog.getName(), catalogRoleName);

integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogIntegrationBase.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,8 @@ public void before(TestInfo testInfo) {
274274
.setStorageConfigInfo(storageConfig)
275275
.build();
276276

277-
managementApi.createCatalog(principalRoleName, catalog);
277+
createPolarisCatalog(catalog);
278+
managementApi.makeAdmin(principalRoleName, catalog);
278279

279280
restCatalogConfig =
280281
IntegrationTestsHelper.mergeFromAnnotatedElements(
@@ -339,6 +340,11 @@ protected RESTCatalog catalog() {
339340
return restCatalog;
340341
}
341342

343+
/** Overridable methods to allow subclasses to execute additional logic on catalog creation. */
344+
protected void createPolarisCatalog(Catalog catalog) {
345+
managementApi.createCatalog(catalog);
346+
}
347+
342348
/**
343349
* Initialize a RESTCatalog for testing.
344350
*

integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogViewIntegrationBase.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,9 @@ public void before(TestInfo testInfo) {
137137
.setProperties(props)
138138
.setStorageConfigInfo(storageConfig)
139139
.build();
140-
managementApi.createCatalog(principalRoleName, catalog);
140+
141+
createPolarisCatalog(catalog);
142+
managementApi.makeAdmin(principalRoleName, catalog);
141143

142144
restCatalog =
143145
IcebergHelper.restCatalog(
@@ -152,6 +154,11 @@ public void cleanUp() {
152154
client.cleanUp(adminToken);
153155
}
154156

157+
/** Overridable methods to allow subclasses to execute additional logic on catalog creation. */
158+
protected void createPolarisCatalog(Catalog catalog) {
159+
managementApi.createCatalog(catalog);
160+
}
161+
155162
/**
156163
* @return The catalog's storage config.
157164
*/

0 commit comments

Comments
 (0)