Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin cryptography to v42.0.4 to resolve vulnerabilities #31

Merged

Conversation

@scott-es
Copy link
Contributor

scott-es commented Apr 9, 2024

I will merge this with the following caveat: the advice to pin cryptography library to 42.0.4 means its a major version upgrade from 41.x. There is not a direct dependency upgrade path through pygithub 1.x (which pulls in cryptography) because 1.x looks to have stopped at 1.59.1 and now pygithub is on 2.x. Probably the right thing to do is to upgrade pygithub to 2.x so it pulls in updated cryptography version. That is also a major version change, so either way there is some risk here but likely this change will be fine. When upgrading to pygithub 2.x rigorous testing should be done

@scott-es scott-es merged commit 51a4d5b into snyk-labs:main Apr 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants