Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add retry to sendTestPayload #4505

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

xzhou-snyk
Copy link
Contributor

Currently for monorepos, the snyk test command succeeds only when all projects in the monorepo succeeds in the test-dep-graph request. If one project fails, the whole snyk test command will fail.

This PR adds retry logic to the test-dep-graph request to increase the chance for snyk test success.

@xzhou-snyk xzhou-snyk requested review from a team as code owners March 31, 2023 11:26
@xzhou-snyk xzhou-snyk marked this pull request as draft March 31, 2023 12:46
@xzhou-snyk xzhou-snyk force-pushed the feat/add-retry-for-sendTestPayload branch from dbb2c92 to 9bf75ab Compare March 31, 2023 13:32
@carlos-snyk carlos-snyk force-pushed the feat/add-retry-for-sendTestPayload branch 3 times, most recently from 4417118 to 0cc0344 Compare April 3, 2023 13:13
@xzhou-snyk xzhou-snyk marked this pull request as ready for review April 3, 2023 17:33
@xzhou-snyk xzhou-snyk force-pushed the feat/add-retry-for-sendTestPayload branch 2 times, most recently from 7956dfb to 31b082e Compare April 4, 2023 14:26
@danlucian danlucian force-pushed the feat/add-retry-for-sendTestPayload branch 5 times, most recently from 52ea516 to 3865aca Compare April 6, 2023 09:03
Copy link
Collaborator

@PeterSchafer PeterSchafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at the test it fails in CI.

@danlucian danlucian force-pushed the feat/add-retry-for-sendTestPayload branch 5 times, most recently from ba40cde to c351df0 Compare April 10, 2023 09:32
@danlucian danlucian force-pushed the feat/add-retry-for-sendTestPayload branch from c351df0 to 5e03771 Compare April 12, 2023 07:08
Co-authored-by: Carlos <carlos@snyk.io>
Cu-authored-by: Lucian <lucian.rosu@snyk.io>
@danlucian danlucian force-pushed the feat/add-retry-for-sendTestPayload branch from 5e03771 to fdf401d Compare April 12, 2023 08:28
@danlucian danlucian enabled auto-merge April 12, 2023 08:33
@danlucian danlucian merged commit 3cc11c8 into master Apr 12, 2023
@danlucian danlucian deleted the feat/add-retry-for-sendTestPayload branch April 12, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants