-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add retry to sendTestPayload #4505
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xzhou-snyk
force-pushed
the
feat/add-retry-for-sendTestPayload
branch
from
March 31, 2023 13:32
dbb2c92
to
9bf75ab
Compare
carlos-snyk
force-pushed
the
feat/add-retry-for-sendTestPayload
branch
3 times, most recently
from
April 3, 2023 13:13
4417118
to
0cc0344
Compare
xzhou-snyk
force-pushed
the
feat/add-retry-for-sendTestPayload
branch
2 times, most recently
from
April 4, 2023 14:26
7956dfb
to
31b082e
Compare
PeterSchafer
reviewed
Apr 5, 2023
PeterSchafer
reviewed
Apr 5, 2023
PeterSchafer
reviewed
Apr 5, 2023
danlucian
force-pushed
the
feat/add-retry-for-sendTestPayload
branch
5 times, most recently
from
April 6, 2023 09:03
52ea516
to
3865aca
Compare
PeterSchafer
approved these changes
Apr 6, 2023
PeterSchafer
requested changes
Apr 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the test it fails in CI.
danlucian
force-pushed
the
feat/add-retry-for-sendTestPayload
branch
5 times, most recently
from
April 10, 2023 09:32
ba40cde
to
c351df0
Compare
PeterSchafer
approved these changes
Apr 11, 2023
danlucian
force-pushed
the
feat/add-retry-for-sendTestPayload
branch
from
April 12, 2023 07:08
c351df0
to
5e03771
Compare
danlucian
approved these changes
Apr 12, 2023
Co-authored-by: Carlos <carlos@snyk.io> Cu-authored-by: Lucian <lucian.rosu@snyk.io>
danlucian
force-pushed
the
feat/add-retry-for-sendTestPayload
branch
from
April 12, 2023 08:28
5e03771
to
fdf401d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently for monorepos, the
snyk test
command succeeds only when all projects in the monorepo succeeds in thetest-dep-graph
request. If one project fails, the wholesnyk test
command will fail.This PR adds retry logic to the
test-dep-graph
request to increase the chance forsnyk test
success.