Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProtostarFixture #566

Merged
merged 46 commits into from
Aug 17, 2022
Merged

ProtostarFixture #566

merged 46 commits into from
Aug 17, 2022

Conversation

Radinyn
Copy link
Contributor

@Radinyn Radinyn commented Aug 2, 2022

edited by: @kasperski95

  • added boundary/learning tests to GatewayFacade
  • added ProtostarFixture utility based on various experiments in order to:
    • simplify process of creating integration tests
    • improve tests readability by:
      • removing implementation details from tests
      • improving collocation (cairo files can be defined in Python test suite)
    • reduce the maintainance cost by:
      • preventing changes in interfaces from propagate to all tests
      • allowing removing compilation output fixtures from the codebase
    • test arguments in integration tests rather than e2e
  • fixed saving Migrator output when cwd was different from the project root

@Radinyn Radinyn force-pushed the feature/call_and_invoke branch from 42b6337 to 20692ec Compare August 8, 2022 14:02
@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #566 (3434ca1) into master (9c4c818) will increase coverage by 1.16%.
The diff coverage is 96.77%.

@@            Coverage Diff             @@
##           master     #566      +/-   ##
==========================================
+ Coverage   82.72%   83.88%   +1.16%     
==========================================
  Files         189      190       +1     
  Lines        6279     6294      +15     
==========================================
+ Hits         5194     5280      +86     
+ Misses       1085     1014      -71     
Impacted Files Coverage Δ
protostar/migrator/migrator.py 96.29% <80.00%> (+7.83%) ⬆️
protostar/__init__.py 100.00% <100.00%> (ø)
protostar/commands/build/build_command.py 90.90% <100.00%> (+14.24%) ⬆️
protostar/commands/init/init_command.py 92.30% <100.00%> (+20.51%) ⬆️
...mmands/init/project_creator/new_project_creator.py 97.50% <100.00%> (+40.74%) ⬆️
protostar/commands/migrate/migrate_command.py 96.15% <100.00%> (+2.03%) ⬆️
protostar/composition_root.py 100.00% <100.00%> (ø)
protostar/migrator/migrator_test.py 100.00% <100.00%> (ø)
...otostar/protostar_toml/io/protostar_toml_reader.py 100.00% <100.00%> (ø)
protostar/starknet_gateway/gateway_facade.py 87.62% <100.00%> (+4.12%) ⬆️
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Radinyn Radinyn force-pushed the feature/call_and_invoke branch from f4db51e to 9aeeae1 Compare August 9, 2022 13:01
@kasperski95 kasperski95 linked an issue Aug 10, 2022 that may be closed by this pull request
@kasperski95 kasperski95 requested a review from mkaput August 12, 2022 16:24
@kasperski95 kasperski95 marked this pull request as ready for review August 12, 2022 16:25
@kasperski95 kasperski95 requested a review from Arcticae August 16, 2022 08:54
Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we please split this PR into migration call and ProtostarFixture? Lots of stuff going on here :(

@kasperski95 kasperski95 requested a review from mkaput August 16, 2022 15:39
@kasperski95 kasperski95 changed the title Migration call and ProtostarFixture ProtostarFixture Aug 16, 2022
protostar/starknet_gateway/gateway_facade.py Outdated Show resolved Hide resolved
protostar/starknet_gateway/starknet_request.py Outdated Show resolved Hide resolved
@mkaput mkaput mentioned this pull request Aug 17, 2022
protostar/commands/init/init_command.py Outdated Show resolved Hide resolved
tests/integration/gateway/gateway_facade_test.py Outdated Show resolved Hide resolved
@kasperski95 kasperski95 requested a review from mkaput August 17, 2022 10:16
protostar/starknet_gateway/gateway_facade.py Outdated Show resolved Hide resolved
protostar/composition_root.py Outdated Show resolved Hide resolved
@kasperski95 kasperski95 requested a review from mkaput August 17, 2022 10:52
@kasperski95 kasperski95 merged commit b497508 into master Aug 17, 2022
@kasperski95 kasperski95 deleted the feature/call_and_invoke branch August 17, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add call migration cheatcode (+ integration tests utils)
3 participants