-
-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tap gesture example crashes in Expo Go #2667
Comments
Updated with Snack https://snack.expo.dev/@henry12345678/courageous-green-truffles?platform=ios |
Hi @henrymoulton! I've tested that and I have not noticed any crash. I've done it by doing the following steps:
I'm using simulator iPhone 15 Pro with iOS 17.0. I've also checked that on physical device with android. Notice that I didn't use |
Hey @m-bert thanks for the reply and attempt to recreate :). Hmm weird, I've got a reproduction of the crash using Snack, can you verify that it crashes in the Snack provided for you? lol.mov |
It does crash on snack, however we had many cases where something doesn't work on snack but works on other devices (physical, emulators/simulators) - that's why we double-check everything outside of snack. |
Okay, I've just got rid of that babel error. The app indeed crashed. Moreover it will crash outside of Expo Go. This is due to |
## Description Some examples in our docs use `Alert.alert`, even though callbacks in new api are automatically workletized. They won't work, because there's no way to access `Alert` on UI thread. Fixes #2667 ## Test plan Checked that both `LongPress` and `Tap` pages were updated.
Description
Simulator.Screen.Recording.-.iPhone.14.-.2023-11-03.at.03.07.54.mp4
Steps to reproduce
npx create-expo-app --template
Snack or a link to a repository
https://gist.github.com/henrymoulton/3f86a2a781f7bb1c814e2ff8b8c0400a
https://snack.expo.dev/@henry12345678/courageous-green-truffles?platform=ios
Gesture Handler version
"2.12.1"
React Native version
0.72.6
Platforms
iOS
JavaScript runtime
Hermes
Workflow
Expo managed workflow
Architecture
Paper (Old Architecture)
Build type
Debug mode
Device
iOS simulator
Device model
No response
Acknowledgements
Yes
The text was updated successfully, but these errors were encountered: