-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android App crash on scrollTo With PanGesture #6418
Comments
I encountered the same issue. Thanks for reporting. I will forward the issue to the person who has been working on this recently. |
@bartlomiejbloniarz To narrow down the suspects for you, this issue occurs even on react-native-74.1 so this not specific to React Native update and i have also tried replacing the deprecated API with the alternatives/new way of handling gesture and faced the same issue. Let me know if you need any help in debugging this. |
Hi @DonBrowny. This problems occurs, because when the user is moving an item, it triggers an update. This update synchronously triggers the logic responsible for scrolling the list (so it triggers another update). This means that there is a recursive call to the |
@bartlomiejbloniarz Thanks for digging into this. Can you please let me know how to enable the FF and test this? |
I just changed the invocation of the FF getter to a |
Got it, Thanks. I will close this issue since it's a issue in the react-native framework and not on this library. |
@DonBrowny I encountered the same problem, is there any solution? |
…roid` Summary: Changelog: [Android][Fixed] Fixes some deadlocks when doing commits and state updates synchronously from the UI thread (e.g.: from reanimated). This removes the gating for the fix to allow recursive commits with synchronous mount on Android. See facebook#44725 (comment) and software-mansion/react-native-reanimated#6418 (comment). Differential Revision: D66095539
…roid` (#47665) Summary: Pull Request resolved: #47665 Changelog: [Android][Fixed] Fixes some deadlocks when doing commits and state updates synchronously from the UI thread (e.g.: from reanimated). This removes the gating for the fix to allow recursive commits with synchronous mount on Android. See #44725 (comment) and software-mansion/react-native-reanimated#6418 (comment). Reviewed By: sammy-SC Differential Revision: D66095539 fbshipit-source-id: 63b8c4d9161a40159601b8e3b45f7e5c7cdd83e4
Description
I am trying to trying to create a Drag-Sort component with react-native-reanimated and react-native-gesture-handler.
I came across this old snack - https://snack.expo.dev/@stewartarmbrecht/apple-music-drag-and-sort-working?platform=android and try to use it with the latest version of react-native and the app crashed when the scrollTo is triggered.
Screen.Recording.2024-08-15.at.11.21.16.PM.mov
Steps to reproduce
yarn start --reset-cache
and open the app in android-emulator
Snack or a link to a repository
https://github.com/DonBrowny/AnimationTest
Reanimated version
3.15.0
React Native version
0.75.1
Platforms
Android
JavaScript runtime
None
Workflow
None
Architecture
Fabric (New Architecture)
Build type
None
Device
Android emulator
Device model
No response
Acknowledgements
Yes
The text was updated successfully, but these errors were encountered: