Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hot-reload in web-example #6121

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Fix hot-reload in web-example #6121

merged 2 commits into from
Jun 14, 2024

Conversation

piaskowyk
Copy link
Member

Summary

This PR resolves the issue of hot reload not working after modifying the example code in a common app or the source code of Reanimated.

Test plan

  • open web-example
  • modify an example in common-app and see if hot-reload happened
  • modify a source code of reanimated and see if hot-reload happened

@piaskowyk piaskowyk requested review from tjzel and m-bert June 14, 2024 08:57
m-bert
m-bert approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@m-bert m-bert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot ❤️

@piaskowyk piaskowyk added this pull request to the merge queue Jun 14, 2024
Merged via the queue into main with commit b1b4eba Jun 14, 2024
5 checks passed
@piaskowyk piaskowyk deleted the @piaskowyk/fix-web-hotreload branch June 14, 2024 11:22
@arenault-pass arenault-pass mentioned this pull request Jul 25, 2024
Closed
This was referenced Jul 25, 2024
Open
Open
@sonlast sonlast mentioned this pull request Jul 27, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Jul 29, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Aug 1, 2024
Closed
@phucle1010 phucle1010 mentioned this pull request Aug 1, 2024
Open
@tiago002pro tiago002pro mentioned this pull request Aug 5, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Aug 12, 2024
Open
@waveyboym waveyboym mentioned this pull request Aug 19, 2024
Closed
@Cabreira97 Cabreira97 mentioned this pull request Aug 23, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Aug 24, 2024
Open
@SanteriMertakorpi SanteriMertakorpi mentioned this pull request Aug 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-bert m-bert m-bert approved these changes

@tjzel tjzel Awaiting requested review from tjzel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piaskowyk @m-bert