Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix C++ linter on CI #6147

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Fix C++ linter on CI #6147

merged 3 commits into from
Jun 20, 2024

Conversation

piaskowyk
Copy link
Member

Summary

This PR aims to fix the C++ linter on CI after transition to the monorepo.

@piaskowyk
Copy link
Member Author

image
This means that it is working again. When we merge this PR into this one, it will show as green 🎉

@piaskowyk piaskowyk mentioned this pull request Jun 20, 2024
Merged
@piaskowyk
Copy link
Member Author

I made a C++ change in this PR to address a new error that appeared after enabling the linter CI.

image

If someone prefers, I can move this change to a separate PR.

@piaskowyk piaskowyk marked this pull request as ready for review June 20, 2024 13:11
tomekzaw
tomekzaw approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@tomekzaw tomekzaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

@piaskowyk piaskowyk added this pull request to the merge queue Jun 20, 2024
Merged via the queue into main with commit 2a6cc4d Jun 20, 2024
12 checks passed
@piaskowyk piaskowyk deleted the @piaskowyk/fix-cpp-linter branch June 20, 2024 13:33
@arenault-pass arenault-pass mentioned this pull request Jul 25, 2024
Closed
This was referenced Jul 25, 2024
Open
Open
@sonlast sonlast mentioned this pull request Jul 27, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Jul 29, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Aug 1, 2024
Closed
@phucle1010 phucle1010 mentioned this pull request Aug 1, 2024
Open
@tiago002pro tiago002pro mentioned this pull request Aug 5, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Aug 12, 2024
Open
@waveyboym waveyboym mentioned this pull request Aug 19, 2024
Closed
@Cabreira97 Cabreira97 mentioned this pull request Aug 23, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Aug 24, 2024
Open
@SanteriMertakorpi SanteriMertakorpi mentioned this pull request Aug 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomekzaw tomekzaw tomekzaw approved these changes

@kmagiera kmagiera Awaiting requested review from kmagiera kmagiera is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piaskowyk @tomekzaw