Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FadingTransition #6183

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Fix FadingTransition #6183

merged 1 commit into from
Jul 1, 2024

Conversation

piaskowyk
Copy link
Member

Summary

This PR aims to fix some unexpected behaviour during FadingTransition.

before after
Screen.Recording.2024-06-28.at.12.31.30.mov
Screen.Recording.2024-06-28.at.12.30.58.mov

Expected behavior:

  • The component stays in the original position.
  • Starts the fade-out animation.
  • Wen component is invisible, changes position to the target position.
  • Starts the fade-in animation.

In the previous approach, when the delayFunction was not specified (when no one called .delay()), the component jumped to the final position after 50ms instead of waiting until the component became invisible.

Test plan

I tested it on the example from #6151

@piaskowyk piaskowyk added this pull request to the merge queue Jul 1, 2024
Merged via the queue into main with commit 188de25 Jul 1, 2024
7 checks passed
@piaskowyk piaskowyk deleted the @piaskowyk/fix-fadingtransition branch July 1, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants