Introduce Import buttons to run tests more easily #6216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
changed the title
piaskowyk
reviewed
Jul 15, 2024
apps/common-app/src/examples/RuntimeTests/RuntimeTestsExample.tsx
Outdated
Show resolved
Hide resolved
apps/common-app/src/examples/RuntimeTests/ReanimatedRuntimeTestsRunner/RuntimeTestsRunner.tsx
Outdated
Show resolved
Hide resolved
apps/common-app/src/examples/RuntimeTests/ReanimatedRuntimeTestsRunner/RuntimeTestsRunner.tsx
Show resolved
Hide resolved
piaskowyk
approved these changes
Jul 16, 2024
This was referenced Sep 24, 2024
This was referenced Oct 1, 2024
This was referenced Oct 3, 2024
This was referenced Oct 4, 2024
This was referenced Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Android Header Fix
This PR should fix problem with additional value added to "top" property on Android. It fixes test cases similar to: withSequence -> Cascade of callbacks -> Test that all callbacks have been called a correct number of times, this test case includes snapshot including top property.
Test plan
I've run all tests on paper, on both IOS and Anroid and didn't notice any unexpected failures.
Several failures of layout transition tests were expected, as their timing was updated after test creation.