From 998c3e310e6cdeab24c2f09092cc90f6003ff65c Mon Sep 17 00:00:00 2001 From: Kacper Kafara Date: Thu, 23 Mar 2023 20:39:41 +0100 Subject: [PATCH] chore: set library namespace in build script (#2005) Since AGP 8.0 project namespace must be set inside build script. It is also the recommended way in Android docs. It is also recommended, that the package name definition is removed from Android manifest file, but I've had some problems in react-native-screens with RN CLI crashing (as it was expecting the package field to exist) & according to this conversation it'll still be legal to leave package name definition in Android manifest file as long as it exactly matches the value in build script. --- android/build.gradle | 1 + 1 file changed, 1 insertion(+) diff --git a/android/build.gradle b/android/build.gradle index c9d66c1e3..209e7256b 100644 --- a/android/build.gradle +++ b/android/build.gradle @@ -39,6 +39,7 @@ def safeExtGet(prop, fallback) { android { compileSdkVersion safeExtGet('compileSdkVersion', 28) + namespace "com.horcrux.svg" // Used to override the NDK path/version on internal CI or by allowing // users to customize the NDK path/version from their root project (e.g. for M1 support)