Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish tests produce different checksums on windows #883

Closed
maciektr opened this issue Nov 8, 2023 · 1 comment · Fixed by #898
Closed

Publish tests produce different checksums on windows #883

maciektr opened this issue Nov 8, 2023 · 1 comment · Fixed by #898
Assignees
@maciektr
Labels
bug Something isn't working

Comments

@maciektr
Copy link
Contributor

maciektr commented Nov 8, 2023

No description provided.

@maciektr maciektr added this to Scarb Nov 8, 2023
@maciektr maciektr converted this from a draft issue Nov 8, 2023
@maciektr maciektr added the bug Something isn't working label Nov 8, 2023
maciektr added a commit that referenced this issue Nov 8, 2023
@maciektr
Ignore tests failing as of #883
dc2b287 
commit-id:1bcbe058
maciektr added a commit that referenced this issue Nov 8, 2023
@maciektr
Ignore tests failing as of #883
76123d8 
commit-id:1bcbe058
maciektr added a commit that referenced this issue Nov 9, 2023
@maciektr
Ignore tests failing as of #883
b248077 
commit-id:1bcbe058
maciektr added a commit that referenced this issue Nov 9, 2023
@maciektr
Ignore tests failing as of #883
52e516d 
commit-id:1bcbe058
github-merge-queue bot pushed a commit that referenced this issue Nov 9, 2023
@maciektr
Ignore tests failing as of #883 (#884)
79b2b50 
commit-id:1bcbe058
maciektr added a commit that referenced this issue Nov 9, 2023
@maciektr
Revert "Ignore tests failing as of #883 (#884)"
21f3d2d 
This reverts commit 79b2b50.
@maciektr maciektr self-assigned this Nov 10, 2023
@maciektr maciektr moved this from Todo to In Progress in Scarb Nov 10, 2023
@mkaput
Copy link
Member

mkaput commented Nov 13, 2023

This is caused by alexcrichton/tar-rs#341. We'll work around this on our side, and I'll submit a patch upstream.

mkaput added a commit that referenced this issue Nov 13, 2023
@mkaput
Use constant mtime for packaged tarballs
843d15a 
Although the `set_metadata_in_mode` call should set `mtime` to a
deterministic value, it fails to do so due to
alexcrichton/tar-rs#341. Also, the constant
value used there is funky and I do not feel convinced about its
stability. Therefore, we use our own `mtime` value explicitly here.

fix #883

Signed-off-by: Marek Kaput <marek.kaput@swmansion.com>
@mkaput mkaput mentioned this issue Nov 13, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Nov 13, 2023
@mkaput
Use constant mtime for packaged tarballs (#898)
4a0a6cf 
Although the `set_metadata_in_mode` call should set `mtime` to a
deterministic value, it fails to do so due to
alexcrichton/tar-rs#341. Also, the constant
value used there is funky and I do not feel convinced about its
stability. Therefore, we use our own `mtime` value explicitly here.

fix #883

Signed-off-by: Marek Kaput <marek.kaput@swmansion.com>
@github-project-automation github-project-automation bot moved this from In Progress to Done in Scarb Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maciektr maciektr

Labels
bug Something isn't working
Projects
Scarb
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use constant mtime for packaged tarballs software-mansion/scarb
2 participants
@mkaput @maciektr