-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scarb Doc: cross item linkage #1690
base: main
Are you sure you want to change the base?
Conversation
c9a7df8
to
bd713b9
Compare
bd713b9
to
5932082
Compare
Review ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it's only me or not, but passing this very specific included_items
everywhere just bothers me a bit 😅 Maybe we can at least hide it behind some abstraction? Something like this is coming to my mind, probably not ideal though: https://gist.github.com/2028017ce043ca137530cd0281fdf55b.git
LMKWYT
I totally agree. Moved the included items to the context. Tbh I don't see any more elegant solve for this problem here, as we need to keep track of those included items throughout creating types and later generating docs. Maybe in the future we can make some refactor, which would keep the context in mind |
Waiting for this to be merged.