Switched to a new Actor implementation #44
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve actor disposing to avoid ClosedSendChannelException.
The issue arises when the code is executed in a specific sequence, leading to a reference to an already closed query.
In the current implementation of the Actor, the Actor is only started when
onLaunchedEffect
is executed. As a result, there is a delay between retrieving the query and starting the Actor, which exposed a design flaw.To address this issue, we needed to carefully examine the implementation of the Actor and ensure that it aligns with the following well-defined requirements:
In the new design,
query.start
is decoupled fromlaunchIn(scope)
, effectively synchronizing the Actor state at the timing of thegetQuery
call. This mechanism allows for the detection of state differences even within delayed disposal processes on the main thread, ensuring safe closure.