Fixed a bug where the RPC coalescer would leave the application with no request even though there were consumers #2819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 341c8b8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @steveluscher and the rest of your teammates on |
steveluscher
force-pushed
the
06-14-fixed_a_bug_where_the_rpc_coalescer_would_leave_the_application_with_no_request_even_though_there_were_consumers
branch
from
f83e65a to
6d95510
Compare
mcintyre94
approved these changes
Jun 14, 2024
Contributor
mcintyre94
left a comment
mcintyre94
left a comment
There was a problem hiding this comment.
LGTM! Nice tests too!
steveluscher
force-pushed
the
06-14-fixed_a_bug_where_the_rpc_coalescer_would_leave_the_application_with_no_request_even_though_there_were_consumers
branch
from
6d95510 to
e572c09
Compare
…no request even though there were consumers
steveluscher
force-pushed
the
06-14-fixed_a_bug_where_the_rpc_coalescer_would_leave_the_application_with_no_request_even_though_there_were_consumers
branch
from
e572c09 to
341c8b8
Compare
steveluscher
deleted the
06-14-fixed_a_bug_where_the_rpc_coalescer_would_leave_the_application_with_no_request_even_though_there_were_consumers
branch
Contributor
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If multiple consumers made the same RPC call, then all of them aborted, then another consumer made the same RPC call, all in the same runloop, you'd end up with zero inflight requests and the remaining callers would never recieve their response.