Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nanliu-staging dependency #250

Closed
blsmth opened this issue Apr 12, 2016 · 5 comments
Closed

nanliu-staging dependency #250

blsmth opened this issue Apr 12, 2016 · 5 comments

Comments

@blsmth
Copy link

blsmth commented Apr 12, 2016

is there an explicit need for this dependency?

That module is not compatible with Puppet >= 4.0. It's blocking me from using puppet-consul in a Puppet 4 environment.

@hopperd
Copy link
Contributor

hopperd commented Apr 12, 2016

That dependency was recently removed and shouldn't be present in the master branch currently and you could test. We haven't cut a release since that merged was done.

@solarkennedy
Copy link
Contributor

I'll make a new release

@solarkennedy
Copy link
Contributor

Go for 1.0.8 without staging.

@solarkennedy
Copy link
Contributor

@blsmth additionally we have puppet 4.1.0 and 4.0.0 in .travis.yaml, so we should be compatible (or at least test against it)

@blsmth
Copy link
Author

blsmth commented Apr 15, 2016

great, thanks @solarkennedy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants