Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enableTagOverride value being written as a quoted string, need to be unquote boolean. #261

Closed
sjoeboo opened this issue Jun 2, 2016 · 0 comments · Fixed by #262
Closed

Comments

@sjoeboo
Copy link
Contributor

sjoeboo commented Jun 2, 2016

The recent addition of the enableTagOverride service config option seems to be writing the value as a quoted string:

"enableTagOverride":"false"

Which cause consul to fail to load the service:

Jun  2 11:06:09 dev01 consul: ==> Error decoding '/etc/consul/service_slurmctld.json': 1 error(s) decoding:                                                               │·
Jun  2 11:06:09 dev01 consul: * 'EnableTagOverride' expected type 'bool', got unconvertible type 'string'

Removing the quotes around false, allows it to load:

"enableTagOverride":false

I'll see if i can work up a fix and submit a pr, but wanted to file the issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant