Fix web_ui installation on Consul 0.6.0 and greater #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Consul version to the web_ui staged file so that upgrades will work without having to delete the old staged file first. Added a version check to handle changes in the 0.6.0 version of the web_ui distribution file that break installation.
|
Hit the same problem :-) Code looks good to me! |
|
Thanks @dbeckham this looks pretty good to me! I know versioncmp can be flaky but I think it is the only real good way to do it, as that is what package uses under the hood now so hopefully it is more stable these days. |
hopperd
added a commit
that referenced
this pull request
Dec 17, 2015
Fix web_ui installation on Consul 0.6.0 and greater
gozer
added a commit
to gozer/nubis-consul
that referenced
this pull request
Dec 19, 2015
it isn't available yet, so pin directly at voxpupuli/puppet-consul#208
limed
added a commit
to nubisproject/nubis-consul
that referenced
this pull request
Dec 19, 2015
Pin at a version of solarkennedy/puppet-consul that includes voxpupuli/puppet-consul#208
JayH5
added a commit
to praekeltfoundation/seed-stack
that referenced
this pull request
Jan 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The web_ui distribution file in Consul 0.6.0 no longer has a
dist/directory as part of the archive's path. This change adds support web_ui archives for versions >= 0.6.0 as well as maintain compatibility with the older releases. It also fixes a specific issue where the genericconsul_web_ui.zipfile name would block upgrades to newer versions. I've also updated existing tests, and written new tests for the version check.If you think the version check in install.pp could be clearer, or if there is anything else you would prefer to be done differently, let me know and I'll be glad to update it.