Allow for stable versions of puppet/archive #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this patch, the current metadata instructs that only unstable versions before 1.0.0 are supported. Since those versions allow for breaking changes, we should allow for the stable v1.
|
This addresses issue #275 |
|
Got it. I'll bump fixtures so we start testing against new versions. |
|
Do not merge yet as puppet/archive v1 does not work with this module. |
|
just beat me to it |
|
Suggest digging in on the changes to the module and just supporting v1 |
|
Ok. I won't make a new release yet until we are sure, but at least you can install it easily to test. If you do know what doesn't work, add some notes to #275 or PR or whatever. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch, the current metadata instructs that only unstable versions before 1.0.0 are supported. Since those versions allow for breaking changes, we should allow for the stable v1.