Decouple service from init system #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR includes commits from the "polish" one, can you rebase? |
tdevelioglu
force-pushed
the
decouple_service_from_init_system
branch
2 times, most recently
from
3ca8247 to
fb46782
Compare
|
Done |
tdevelioglu
force-pushed
the
decouple_service_from_init_system
branch
from
fb46782 to
94506db
Compare
tdevelioglu
force-pushed
the
decouple_service_from_init_system
branch
from
94506db to
a87c3a9
Compare
|
I understand what you are trying achieve. What if instead of a new parameter we reused existing the |
Previously the logic didn't make sense, where one could pass a bool to the parameter `init_style` that expects a string to toggle the management of service files in the init system and it was impossible to let the module manage the service but not the init system. This breaks the common case of where you want to let a package prep the init system but still let the module manage the service. This commit decouples the service resource from management of the init system so it offers the choice of using the module-supplied init files. It adds support for a magic value `unmanaged` on parameter `init_style` that disables management of the init system.
tdevelioglu
force-pushed
the
decouple_service_from_init_system
branch
from
a87c3a9 to
f85fcba
Compare
|
Sounds good to me, how is this ? |
solarkennedy
approved these changes
Sep 20, 2016
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decouple managing service and init system from eachother.
Previously the logic didn't make sense, where one could pass a bool
to the parameter
init_stylethat expects a string to toggle themanagement of service files in the init system and it was impossible to
let the module manage the service but not the init system.
This breaks the common case of where you want to let a package prep the
init system but still let the module manage the service.
This commit decouples the service resource from management of the init
system so it offers the choice of using the module-supplied init files.
It adds support for a magic value
unmanagedon parameterinit_stylethatdisables management of the init system.