(retry) Service Definition documentation and fix #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is odd: the build failure doesn't seem to be related to my changes. Any thoughts? |
|
|
||
| ```puppet | ||
| consul::service { 'redis': | ||
| tags => ['master'], |
There was a problem hiding this comment.
Can you line up the arrows to conform to the style guide?
|
10-4. I should be able to take care of this today |
|
I pulled the test you wrote for #13, hope thats what you're looking for. |
|
Look great!
Thank you for the effort! |
solarkennedy
added a commit
that referenced
this pull request
Sep 26, 2014
(retry) Service Definition documentation and fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a
$port * 1to convert the string value to an int so it will render in json without quotes, and documented how to use this define in the README.