Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import install module from rich.traceback causing traceback to be forced to rich when import springs is executed. #16

Closed
davidlin409 opened this issue Mar 30, 2023 · 1 comment · Fixed by #17
Closed

Import install module from rich.traceback causing traceback to be forced to rich when import springs is executed. #16

davidlin409 opened this issue Mar 30, 2023 · 1 comment · Fixed by #17

Comments

@davidlin409
Copy link

davidlin409 commented Mar 30, 2023 •
edited
Loading

In nicknames.py, there is a line

LOGGER = configure_logging(__name__)

Above line will install rich-traceback to system, when this file is executed. Meanwhile, simple import springs will already execute nicknames.py, which means, importing springs will already install rich handler, while there is no "uninstall" mechanism for it.

So, is it possible to avoid configure_logging at global scope?
@soldni soldni mentioned this issue Apr 3, 2023
Merged
@soldni soldni closed this as completed in #17 Apr 3, 2023
@soldni
Copy link
Owner

soldni commented Apr 3, 2023

thank you for the report! this is now fixed & pushed to PyPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed rich logger during module import soldni/springs
2 participants
@soldni @davidlin409