Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🤔 play button vertical alignment of sd-video with description #1650

Open
9 tasks
paulovareiro29 opened this issue Nov 15, 2024 · 2 comments
Open
9 tasks
Assignees
Labels
🔧 code needs changes in code

Comments

@paulovareiro29
Copy link
Contributor

Current behavior

The current implementation of the sd-video is breaking the vertical alignment of the play button when a description is added.

Also, clicking on the description activates the video.

Expected behavior

  • The play button should be centered relatively only on the video element.
  • Clicking the description should not start the video.

Steps to reproduce

  • Go to the video template Video with Description
  • Lower viewport width to better see the alignment issue.
  • Click on the description to play the video.

Suggested Reproduction Tools

Video template docs

Technical Information

In the sd-video, the custom play button is an overlay button. The description is being injected alongside the play button, making the button use the description height as part of the its height calculation. Clicking the description plays the video because the button is overlapping the description.

DoR

  • Item has business value
  • Item has been estimated by the team
  • Item is clear and well-defined
  • Item dependencies have been identified

DoD

  • Documentation has been created/updated (if applicable)
  • Migration Guide has been created/updated (if applicable)
  • Relevant E2E tests (Features, A11y, Bug fixes) are created/updated
  • Relevant stories (Features, A11y) are created/updated
  • Implementation works successfully on feature branch
@paulovareiro29
Copy link
Contributor Author

Duplicated issue since it will be fixed with #1631 fixes

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Solid Design System Project Board Nov 15, 2024
@paulovareiro29
Copy link
Contributor Author

Not duplicated after all, as it is not on the scope of #1631. Reopening

@github-project-automation github-project-automation bot moved this from ✅ Done to ⚙️ To be refined in Solid Design System Project Board Nov 19, 2024
@paulovareiro29 paulovareiro29 removed their assignment Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 code needs changes in code
Projects
Status: ⚙️ To be refined
Development

No branches or pull requests

2 participants