-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sd-teaser and sd-teaser-media a11y #1625
base: main
Are you sure you want to change the base?
Conversation
🚀 Storybook has been deployed for branch |
on the variants the order is wrong. "primary" should be the last on the list to match the samples. can you change this please? |
change the "Meta Slot" description to: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
on teaser temlate instead of: "Unclickable Teaser With Button" change to "Unclickable Teaser with Button" please |
for teaser media template instead of "Teaser Media With Link" change to "Teaser Media with Link" |
for the Teaser Media Overrides sample template can you make it more similar to figma? |
on the 1st sample for teaser in figma we have the vertical variant. |
src="./placeholders/images/coins.jpg" | ||
alt="Close-up of hands stacking coins into small piles on a table, suggesting financial planning or saving." | ||
/> | ||
<img class="w-full aspect-ratio" src="./placeholders/images/coins.jpg" alt="" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, if these really count as decorative. Would love to hear Debbies thoughts on that: https://solid-design-system.github.io/solid/fix_sd-teaser-and-teaser-media-a11y/?path=/docs/templates-teaser--docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As in the examples the images are not decorative but delivering emotions (e.g. Future is an attitude -> man with young children) I would actually add a meaningful alt attribute.
I suggest to add a small a11y hint though which says something like in case your used image is decorative keep it empty...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I don't feel the images add relevant information to the text and are more "eye candy", but I guess this goes into what we discussed about acessibility not being an exact science. I will add back some alt texts and the suggested a11y hint.
Updated
Updated
Updated
Synced directly on teams call. There's a ticket to make the headline font size overridable. Decision now was to update Figma to resemble Storybook. |
Description:
This PR closes 1491, 1526 and 1527
Note: I removed the alt text from the images in the templates, because they are decorative images and do not need alt text since no important information is conveyed by them.
Definition of Reviewable: