fix: improve sd-video a11y

packages/components/src/components/video/video.test.ts

@@ -1,12 +1,13 @@
 import { expect, fixture, html, waitUntil } from '@open-wc/testing';
+import { sendKeys } from '@web/test-runner-commands';
 import sinon from 'sinon';
 import type SdVideo from './video';
 
 const defaultSlot = html`<video controls>
   <source src="http://media.w3.org/2010/05/sintel/trailer.mp4" type="video/mp4" />
   Your browser does not support the video tag.
 </video>`;
-const posterSlot = html`<img slot="poster" alt="poster" src="" />`;
+const posterSlot = html`<img slot="poster" alt="A generic placeholder video" src="" />`;
 const playIconSlot = html`<sd-icon library="system" name="start" color="primary"></sd-icon>`;
 const variants = {
   default: html`<sd-video>${defaultSlot}</sd-video>`,
@@ -85,29 +86,59 @@ describe('<sd-video>', () => {
     });
   });
 
-  describe('when "play-icon" is interacted with via Keyboard', () => {
-    it('emits "sd-play" event ', async () => {
-      const el: SdVideo = await fixture(variants.default);
-      const playSpy = sinon.spy();
-      el.addEventListener('sd-play', playSpy);
-      el.shadowRoot?.querySelector('button')?.dispatchEvent(new KeyboardEvent('keydown', { key: 'Enter' }));
-      expect(playSpy.calledOnce).to.be.true;
+  describe('when interacted with via Keyboard', () => {
+    describe('"play-icon"', () => {
+      it('emits "sd-play" event', async () => {
+        const el: SdVideo = await fixture(variants.default);
+        const playSpy = sinon.spy();
+        el.addEventListener('sd-play', playSpy);
+        el.shadowRoot?.querySelector('button')?.dispatchEvent(new KeyboardEvent('keydown', { key: 'Enter' }));
+        expect(playSpy.calledOnce).to.be.true;
+      });
+
+      it('toggles playing property', async () => {
+        const el: SdVideo = await fixture(variants.default);
+        el.shadowRoot?.querySelector('button')?.dispatchEvent(new KeyboardEvent('keydown', { key: 'Enter' }));
+        expect(el.playing).to.be.true;
+      });
+
+      it('updates overlay class', async () => {
+        const el: SdVideo = await fixture(variants.overlay);
+        await el.updateComplete;
+        expect(el.shadowRoot!.querySelector('#overlay.opacity-100')).to.exist;
+
+        el.shadowRoot?.querySelector('button')?.dispatchEvent(new KeyboardEvent('keydown', { key: 'Enter' }));
+        await el.updateComplete;
+        expect(el.shadowRoot!.querySelector('#overlay.opacity-0')).to.exist;
+      });
     });
 
-    it('toggles playing property', async () => {
-      const el: SdVideo = await fixture(variants.default);
-      el.shadowRoot?.querySelector('button')?.dispatchEvent(new KeyboardEvent('keydown', { key: 'Enter' }));
-      expect(el.playing).to.be.true;
-    });
+    // Handle tabbing for Safari and other Browsers, see https://github.com/microsoft/playwright/issues/2114#issuecomment-1517642401
+    const tabKey =
+      navigator.userAgent.includes('Safari') && !navigator.userAgent.includes('HeadlessChrome') ? 'Alt+Tab' : 'Tab';
 
-    it('updates overlay class', async () => {
-      const el: SdVideo = await fixture(variants.overlay);
+    it('video is not focusable before played', async () => {
+      const el: SdVideo = await fixture(variants.all);
+
+      await sendKeys({ press: tabKey });
       await el.updateComplete;
-      expect(el.shadowRoot!.querySelector('#overlay.opacity-100')).to.exist;
+      await sendKeys({ press: tabKey });
+      await el.updateComplete;
+
+      expect(el.querySelector('video')).to.not.focus;
+    });
+
+    it('video is focusable after played', async () => {
+      const el: SdVideo = await fixture(variants.all);
 
-      el.shadowRoot?.querySelector('button')?.dispatchEvent(new KeyboardEvent('keydown', { key: 'Enter' }));
+      el.shadowRoot?.querySelector('button')?.click();
+
+      await sendKeys({ press: tabKey });
       await el.updateComplete;
-      expect(el.shadowRoot!.querySelector('#overlay.opacity-0')).to.exist;
+      await sendKeys({ press: tabKey });
+      await el.updateComplete;
+
+      expect(el.querySelector('video')).to.focus;
     });
   });
 

packages/components/src/components/video/video.ts

@@ -51,6 +51,10 @@ export default class SdVideo extends SolidElement {
     return null;
   }
 
+  private get video(): HTMLVideoElement | null {
+    return this.querySelector('video');
+  }
+
   /** Fade out poster after initial play. */
   private fadeoutPoster(): void {
     if (this.poster instanceof HTMLImageElement) {
@@ -65,19 +69,29 @@ export default class SdVideo extends SolidElement {
     }
   }
 
+  private setVideoInert(inert?: boolean): void {
+    if (inert) {
+      this.video?.setAttribute('inert', '');
+    } else {
+      this.video?.removeAttribute('inert');
+    }
+  }
+
   /** Utility function to group play behaviors. */
   private play() {
     this.emit('sd-play');
     this.playing = true;
+    this.video?.play();
     this.fadeoutPoster();
+    this.setVideoInert(false);
   }
 
   /** Restrict keydown control to enter and space bar to mimic the native video tag behavior. If a KeyboardEvent is used, refocus on the native video element to give the user seamless keyboard control. */
   private handleKeydown(e: MouseEvent | KeyboardEvent) {
     if (e instanceof KeyboardEvent && (e.key === 'Enter' || e.key === ' ')) {
       this.play();
       setTimeout(() => {
-        this.querySelector('video')?.focus();
+        this.video?.focus();
       });
     }
   }
@@ -95,6 +109,7 @@ export default class SdVideo extends SolidElement {
 
   connectedCallback(): void {
     super.connectedCallback();
+    this.setVideoInert(true);
     this.resizeObserver = new ResizeObserver(() => this.handleButtonResize());
 
     this.updateComplete.then(() => {
@@ -118,15 +133,15 @@ export default class SdVideo extends SolidElement {
           @keydown=${this.handleKeydown}
           class=${cx(
             this.playing && 'pointer-events-none',
-            'w-full h-full absolute top-0 left-0 z-30 text-primary hover:text-primary-500 sd-interactive sd-interactive--reset focus-visible:focus-outline'
+            'group w-full h-full absolute top-0 left-0 z-30 text-primary hover:text-primary-500 sd-interactive sd-interactive--reset focus-visible:focus-outline'
           )}
         >
           <div
             part="play-button-bg"
             class=${cx(
               this.playing ? 'opacity-0' : 'opacity-100',
               this.isBelowBreakpoint ? 'w-[48px] h-[48px]' : 'w-[96px] h-[96px]',
-              'absolute left-1/2 top-1/2 -translate-x-1/2 -translate-y-1/2 p-4 bg-white bg-opacity-75 rounded-full play-pause-transition'
+              'absolute left-1/2 top-1/2 -translate-x-1/2 -translate-y-1/2 p-4 bg-white bg-opacity-75 rounded-full play-pause-transition outline-2 outline-offset-2 group-focus-visible:outline'
             )}
           >
             <slot name="play-icon" part="play-icon" class=${cx(this.isBelowBreakpoint ? 'text-[2rem]' : 'text-[4rem]')}>

packages/docs/.storybook/main.ts

@@ -32,6 +32,10 @@ export default {
       from: '../../placeholders/src/videos',
       to: '/placeholders/videos'
     },
+    {
+      from: '../../placeholders/src/captions',
+      to: '/placeholders/captions'
+    },
     {
       from: '../../placeholders/src/audio',
       to: '/placeholders/audio'

packages/docs/src/stories/components/video.stories.ts

@@ -50,12 +50,19 @@ export const VideoElementWithPosterSlot = {
   render: () => html`
     <sd-video>
       <video controls="" id="video-example" class="w-[854px] aspect-video">
-        <source src="./placeholders/videos/ui-placeholder-video.mp4" type="video/mp4" />
+        <source src="./placeholders/videos/ui-placeholder-video.webm" type="video/webm" />
+        <track
+          label="English"
+          kind="subtitles"
+          srclang="en"
+          src="./placeholders/captions/ui-placeholder-video.vtt"
+          default
+        />
         Your browser does not support the video tag.
       </video>
       <img
         slot="poster"
-        alt="poster"
+        alt="A generic placeholder video"
         class="w-[854px] aspect-video cover"
         src="./placeholders/images/architecture.jpg"
       />

packages/docs/src/stories/components/video.test.stories.ts

@@ -25,7 +25,7 @@ const posterConstant: ConstantDefinition = {
   type: 'slot',
   name: 'poster',
   value:
-    '<img slot="poster" alt="poster" class="w-[854px] aspect-video cover" src="./placeholders/images/architecture.jpg" />'
+    '<img slot="poster" alt="A generic placeholder video" class="w-[854px] aspect-video cover" src="./placeholders/images/architecture.jpg" />'
 };
 const iconConstant: ConstantDefinition = {
   type: 'slot',

packages/docs/src/stories/templates/video-with-description-and-copyright.stories.ts

@@ -20,7 +20,12 @@ export const VideoWithDescription = {
         <source src="./placeholders/videos/ui-placeholder-video.mp4" type="video/mp4" />
         Your browser does not support the video tag.
       </video>
-      <img slot="poster" alt="poster" class="aspect-video cover" src="./placeholders/images/architecture.jpg" />
+      <img
+        slot="poster"
+        alt="A generic placeholder video"
+        class="aspect-video cover"
+        src="./placeholders/images/architecture.jpg"
+      />
       <figcaption class="mt-4">
         Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et
         dolore magna aliquyam erat, sed diam voluptua.
@@ -42,7 +47,12 @@ export const VideoWithCopyright = {
           <source src="./placeholders/videos/ui-placeholder-video.mp4" type="video/mp4" />
           Your browser does not support the video tag.
         </video>
-        <img slot="poster" alt="poster" class="aspect-video cover" src="./placeholders/images/architecture.jpg" />
+        <img
+          slot="poster"
+          alt="A generic placeholder video"
+          class="aspect-video cover"
+          src="./placeholders/images/architecture.jpg"
+        />
       </sd-video>
     </div>
   `