Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix improper super calls in proper_super_calls.dart and add Disposable interface in proper_super_calls_test.dart #160

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

4akloon
Copy link
Contributor

@4akloon 4akloon commented Apr 17, 2024

No description provided.

@4akloon 4akloon linked an issue Apr 17, 2024 that may be closed by this pull request
Comment on lines 79 to 81
abstract interface class Disposable {
void dispose();
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a comment here explaining what this testing is?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, added)

@illia-romanenko illia-romanenko merged commit 133f96c into master Apr 18, 2024
2 checks passed
@illia-romanenko illia-romanenko deleted the 159-some-of-the-rules-throw branch April 18, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

some of the rules throw
3 participants