Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix avoid_unused_parameters false reporting #67

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Fix avoid_unused_parameters false reporting #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/lints/avoid_unused_parameters/avoid_unused_parameters_visitor.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ class AvoidUnusedParametersVisitor extends RecursiveAstVisitor<void> {
_getUnusedParameters(
node.body,
parameters.parameters,
initializers: node.initializers,
).whereNot(nameConsistsOfUnderscoresOnly),
);
}
Expand Down Expand Up @@ -104,11 +105,13 @@ class AvoidUnusedParametersVisitor extends RecursiveAstVisitor<void> {

Set<FormalParameter> _getUnusedParameters(
AstNode body,
Iterable<FormalParameter> parameters,
) {
Iterable<FormalParameter> parameters, {
NodeList<AstNode>? initializers,
}) {
final result = <FormalParameter>{};
final visitor = _IdentifiersVisitor();
body.visitChildren(visitor);
initializers?.accept(visitor);

final allIdentifierElements = visitor.elements;

Expand Down
10 changes: 10 additions & 0 deletions lint_test/avoid_unused_parameters_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,3 +109,13 @@ class TestWidget extends StatelessWidget {
return const Placeholder();
}
}

class UsingConstructorParameterInInitializer {
final int _value;

UsingConstructorParameterInInitializer(int value) : _value = value;

void printValue() {
print(_value);
}
}