From 2e922399236ee5b86ac50143794b8939c48ccc69 Mon Sep 17 00:00:00 2001 From: Brenley Dueck Date: Thu, 30 Jan 2025 21:15:37 -0600 Subject: [PATCH 1/2] Fix vite6 environment detection --- src/index.ts | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/index.ts b/src/index.ts index 9f19c16..04b9126 100644 --- a/src/index.ts +++ b/src/index.ts @@ -181,6 +181,7 @@ export default function solidPlugin(options: Partial = {}): Plugin { let needHmr = false; let replaceDev = false; let projectRoot = process.cwd(); + let isTestMode = false; return { name: 'solid', @@ -190,6 +191,7 @@ export default function solidPlugin(options: Partial = {}): Plugin { // We inject the dev mode only if the user explicitely wants it or if we are in dev (serve) mode replaceDev = options.dev === true || (options.dev !== false && command === 'serve'); projectRoot = userConfig.root; + isTestMode = userConfig.mode === 'test'; if (!userConfig.resolve) userConfig.resolve = {}; userConfig.resolve.alias = normalizeAliases(userConfig.resolve && userConfig.resolve.alias); @@ -270,7 +272,12 @@ export default function solidPlugin(options: Partial = {}): Plugin { config.resolve.conditions = [...defaultServerConditions]; } } - config.resolve.conditions.push('solid'); + config.resolve.conditions = [ + 'solid', + ...(replaceDev ? ['development'] : []), + ...(isTestMode && !opts.isSsrTargetWebworker ? ['browser'] : []), + ...config.resolve.conditions, + ]; }, configResolved(config) { From 2a72396879b74a20350e247cc39ac185a0dc8d9c Mon Sep 17 00:00:00 2001 From: Ryan Carniato Date: Fri, 31 Jan 2025 08:24:24 -0800 Subject: [PATCH 2/2] Create lucky-hats-arrive.md --- .changeset/lucky-hats-arrive.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/lucky-hats-arrive.md diff --git a/.changeset/lucky-hats-arrive.md b/.changeset/lucky-hats-arrive.md new file mode 100644 index 0000000..7334eb8 --- /dev/null +++ b/.changeset/lucky-hats-arrive.md @@ -0,0 +1,5 @@ +--- +"vite-plugin-solid": patch +--- + +Fix vite6 environment detection