From 0541c654d484c0dabcb09cced9fe80706953c78e Mon Sep 17 00:00:00 2001
From: Alberto Vena <kennyadsl@gmail.com>
Date: Tue, 2 Mar 2021 10:23:28 +0100
Subject: [PATCH] Configure Active Storage on dummy apps for extensions

Copying the .yml configuration file into config/storage/test.yml
will automatically configure Active Storage in that env [1].

The configuration key needs to be the same of the service
set into config/environments/test.rb.

When testing extensions against old versions of Solidus, it
will not use Active Storage so, it should not be harmful to
have it configured anyway.

[1]: https://github.com/rails/rails/blob/66b861f24cd8ca34b726f77b46f6b25b21f0b972/activestorage/lib/active_storage/engine.rb#L115-L132
---
 core/lib/generators/spree/dummy/dummy_generator.rb          | 1 +
 core/lib/generators/spree/dummy/templates/rails/storage.yml | 3 +++
 core/lib/generators/spree/dummy/templates/rails/test.rb     | 2 ++
 3 files changed, 6 insertions(+)
 create mode 100644 core/lib/generators/spree/dummy/templates/rails/storage.yml

diff --git a/core/lib/generators/spree/dummy/dummy_generator.rb b/core/lib/generators/spree/dummy/dummy_generator.rb
index 09582e599bd..2292761e5d1 100644
--- a/core/lib/generators/spree/dummy/dummy_generator.rb
+++ b/core/lib/generators/spree/dummy/dummy_generator.rb
@@ -55,6 +55,7 @@ def test_dummy_config
       @database = options[:database]
 
       template "rails/database.yml", "#{dummy_path}/config/database.yml", force: true
+      template "rails/storage.yml", "#{dummy_path}/config/storage/test.yml", force: true
       template "rails/boot.rb", "#{dummy_path}/config/boot.rb", force: true
       template "rails/application.rb.tt", "#{dummy_path}/config/application.rb", force: true
       template "rails/routes.rb", "#{dummy_path}/config/routes.rb", force: true
diff --git a/core/lib/generators/spree/dummy/templates/rails/storage.yml b/core/lib/generators/spree/dummy/templates/rails/storage.yml
new file mode 100644
index 00000000000..9f2a8d8c360
--- /dev/null
+++ b/core/lib/generators/spree/dummy/templates/rails/storage.yml
@@ -0,0 +1,3 @@
+test:
+  service: Disk
+  root: <%= File.expand_path("#{dummy_path}/tmp/storage", destination_root) %>
diff --git a/core/lib/generators/spree/dummy/templates/rails/test.rb b/core/lib/generators/spree/dummy/templates/rails/test.rb
index 6c029ce51cc..0a2d9aabe8f 100644
--- a/core/lib/generators/spree/dummy/templates/rails/test.rb
+++ b/core/lib/generators/spree/dummy/templates/rails/test.rb
@@ -29,6 +29,8 @@
   config.action_mailer.delivery_method = :test
   ActionMailer::Base.default from: "solidus@example.com"
 
+  config.active_storage.service = :test
+
   # Raise on deprecation warnings
   if ENV['SOLIDUS_RAISE_DEPRECATIONS'].present?
     Spree::Deprecation.behavior = :raise