From 2e6aef021877daefcdf8861e2994fba7c57d5f13 Mon Sep 17 00:00:00 2001
From: John Hawthorn <john@stembolt.com>
Date: Mon, 13 Mar 2017 16:40:31 -0700
Subject: [PATCH] Remove StockMovements#new

I broke this page over a year ago in
0f5c0d0d30135c2ca40286592415054db4f2df56

Nobody noticed so it should probably be safe to remove.

This page previously provided an interface to manually create a stock
movement. I think this can more easily be done by editing stock from our
stock management page.
---
 .../app/assets/javascripts/spree/backend.js   |  1 -
 .../spree/backend/stock_movement.js.coffee    | 21 -------------------
 .../admin/stock_movements/_form.html.erb      | 12 -----------
 .../admin/stock_movements/index.html.erb      |  6 ------
 .../spree/admin/stock_movements/new.html.erb  | 15 -------------
 backend/config/routes.rb                      |  2 +-
 6 files changed, 1 insertion(+), 56 deletions(-)
 delete mode 100644 backend/app/assets/javascripts/spree/backend/stock_movement.js.coffee
 delete mode 100644 backend/app/views/spree/admin/stock_movements/_form.html.erb
 delete mode 100644 backend/app/views/spree/admin/stock_movements/new.html.erb

diff --git a/backend/app/assets/javascripts/spree/backend.js b/backend/app/assets/javascripts/spree/backend.js
index 0433a3fbe20..1d977e88abc 100644
--- a/backend/app/assets/javascripts/spree/backend.js
+++ b/backend/app/assets/javascripts/spree/backend.js
@@ -57,7 +57,6 @@
 //= require spree/backend/stock_management/index_add_forms
 //= require spree/backend/stock_management/index_update_forms
 //= require spree/backend/stock_management/stock_item
-//= require spree/backend/stock_movement
 //= require spree/backend/stock_transfers/count_update_forms
 //= require spree/backend/stock_transfers/edit
 //= require spree/backend/stock_transfers/receive
diff --git a/backend/app/assets/javascripts/spree/backend/stock_movement.js.coffee b/backend/app/assets/javascripts/spree/backend/stock_movement.js.coffee
deleted file mode 100644
index 84ab9b43ff4..00000000000
--- a/backend/app/assets/javascripts/spree/backend/stock_movement.js.coffee
+++ /dev/null
@@ -1,21 +0,0 @@
-jQuery ->
-  el = $('#stock_movement_stock_item_id')
-  if el.length
-    el.select2
-      placeholder: "Find a stock item" # translate
-      ajax:
-        url: Spree.routes.stock_items_api(el.data('stock-location-id'))
-        params: { "headers": { "X-Spree-Token": Spree.api_key } }
-        data: (term, page) ->
-          q:
-            variant_product_name_cont: term
-          per_page: 50
-          page: page
-          token: Spree.api_key
-        results: (data, page) ->
-          more = (page * 50) < data.count
-          return { results: data.stock_items, more: more }
-      formatResult: (stock_item) ->
-        variantTemplate({ variant: stock_item.variant })
-      formatSelection: (stock_item, container, excapeMarkup) ->
-        Select2.util.escapeMarkup("#{stock_item.variant.name} (#{stock_item.variant.options_text})")
diff --git a/backend/app/views/spree/admin/stock_movements/_form.html.erb b/backend/app/views/spree/admin/stock_movements/_form.html.erb
deleted file mode 100644
index f54c7d06306..00000000000
--- a/backend/app/views/spree/admin/stock_movements/_form.html.erb
+++ /dev/null
@@ -1,12 +0,0 @@
-<div data-hook="admin_stock_movements_form_fields" class="row">
-  <div class="col-xs-9">
-    <%= f.field_container :quantity do %>
-      <%= f.label :quantity %>
-      <%= f.text_field :quantity %>
-    <% end %>
-    <%= f.field_container :stock_item_id do %>
-      <%= f.label :stock_item_id, Spree::StockItem.model_name.human %>
-      <%= f.text_field 'stock_item_id', class: 'fullwidth', :'data-stock-location-id' => params[:stock_location_id] %>
-    <% end %>
-  </div>
-</div>
diff --git a/backend/app/views/spree/admin/stock_movements/index.html.erb b/backend/app/views/spree/admin/stock_movements/index.html.erb
index a8737bc2896..7256ff8c9dd 100644
--- a/backend/app/views/spree/admin/stock_movements/index.html.erb
+++ b/backend/app/views/spree/admin/stock_movements/index.html.erb
@@ -4,12 +4,6 @@
 
 
 <% content_for :page_actions do %>
-  <% if can?(:create, Spree::StockMovement) %>
-    <li>
-      <%= button_link_to Spree.t(:new_stock_movement), new_admin_stock_location_stock_movement_path(@stock_location), id: 'admin_new_stock_movement_link' %>
-    </li>
-  <% end %>
-
   <% if can?(:display, Spree::StockLocation) %>
     <li>
       <%= link_to_with_icon 'arrow-left', Spree.t(:back_to_stock_locations_list), admin_stock_locations_path, class: 'button' %>
diff --git a/backend/app/views/spree/admin/stock_movements/new.html.erb b/backend/app/views/spree/admin/stock_movements/new.html.erb
deleted file mode 100644
index 307c80336a8..00000000000
--- a/backend/app/views/spree/admin/stock_movements/new.html.erb
+++ /dev/null
@@ -1,15 +0,0 @@
-<% admin_breadcrumb(Spree.t(:new_stock_movement)) %>
-
-
-<% content_for :page_actions do %>
-  <li><%= link_to_with_icon 'arrow-left', Spree.t(:back_to_stock_movements_list), admin_stock_location_stock_movements_path(@stock_location), class: 'button' %></li>
-<% end %>
-
-<%= render partial: 'spree/shared/error_messages', locals: { target: @stock_movement } %>
-
-<%= form_for [:admin, @stock_location, @stock_movement] do |f| %>
-  <fieldset class="no-border-top">
-    <%= render partial: 'form', locals: { f: f } %>
-    <%= render partial: 'spree/admin/shared/new_resource_links', locals: { collection_url: admin_stock_location_stock_movements_path(@stock_location) } %>
-  </fieldset>
-<% end %>
diff --git a/backend/config/routes.rb b/backend/config/routes.rb
index a99c0365086..5bac26afcc8 100644
--- a/backend/config/routes.rb
+++ b/backend/config/routes.rb
@@ -167,7 +167,7 @@
     end
 
     resources :stock_locations do
-      resources :stock_movements, except: [:edit, :update, :destroy]
+      resources :stock_movements, only: [:index]
       collection do
         post :transfer_stock
         post :update_positions