From 88b7c976f3e8a0da1666a2ba94f8f47690abe0ca Mon Sep 17 00:00:00 2001 From: Clarke Brunsdon Date: Tue, 25 Jul 2017 13:19:30 -0700 Subject: [PATCH] Remove hacked support for kaminari page name Historically this looks like it is to support kaminari and will_paginate side-by-side, which doesn't seem like a reasonable thing for us to care about inside of core. Anyone that wanted this functionality can use it inside their own app. Also it wasn't tested. --- core/app/models/spree/base.rb | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/core/app/models/spree/base.rb b/core/app/models/spree/base.rb index a413e7745ee..558515fa78f 100644 --- a/core/app/models/spree/base.rb +++ b/core/app/models/spree/base.rb @@ -23,6 +23,10 @@ def self.preference(*args) if Kaminari.config.page_method_name != :page def self.page(num) + Spree::Deprecation.warn \ + "Redefining Spree::Base.page for a different kaminari page name is better done inside " \ + "your own app. This will be removed from future versions of solidus." + send Kaminari.config.page_method_name, num end end