From 91c1b7fe69f6a34bea71f2e3f9039a050fc2bfb4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marc=20Busqu=C3=A9?= Date: Thu, 10 Jun 2021 12:25:36 +0200 Subject: [PATCH] Remove staled comment We had a `TODO` item to be removed when an issue on Rails was fixed, but they have closed the issue because they think they don't need to fix it. --- core/app/models/spree/order.rb | 3 --- 1 file changed, 3 deletions(-) diff --git a/core/app/models/spree/order.rb b/core/app/models/spree/order.rb index bbe3edd6940..9e50a09694e 100644 --- a/core/app/models/spree/order.rb +++ b/core/app/models/spree/order.rb @@ -490,9 +490,6 @@ def create_proposed_shipments raise CannotRebuildShipments.new(I18n.t('spree.cannot_rebuild_shipments_shipments_not_pending')) else shipments.destroy_all - # TODO: We can use `self.shipments#=` instead of `#push` when - # https://github.com/rails/rails/issues/42102 is fixed and we deprecate - # Rails versions with the bug shipments.push(*Spree::Config.stock.coordinator_class.new(self).shipments) end end