Fix install generator on namespaced extensions #4327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to #4302, `camelize` was called on the `LIB_NAME` value which converts `/` to `::`. This behaviour worked for namespaced extensions because we were invoking the class directly, instead of through the `bin/rails` bin stub. To fix this, we convert to a "rake style" namespace by replacing `/` with `:`. Co-authored-by: Chris Todorov <chris@super.gd> Co-authored-by: Adam Mueller <adam@super.gd>
jarednorman
approved these changes
Apr 4, 2022
|
@gsmendoza tagging you for visibility! Thanks @nvandoorn and @adammathys! |
|
@nvandoorn Thanks for fixing the namespace! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prior to #4302,
camelizewas called on theLIB_NAMEvalue which converts/to::. This behaviour worked fornamespaced extensions because we were invoking the class directly,
instead of through the
bin/railsbin stub.The change to run the generator through the binstub breaks for extensions with a LIB_NAME like “super_good/solidus_taxjar” because Rails will not be able to find he task correctly.
To fix this, we convert to a "rake style" namespace by replacing
/with
:.Checklist: