Restore --payment-method= for solidus:install on v3.2
#4673
Conversation
This reverts commit 1bf1963.
elia
force-pushed
the
elia/restore-payment-method-on-3-2
branch
from
b5ca42d to
84e1f91
Compare
elia
changed the title
--payment-method= for `solidus:install on v3.2--payment-method= for solidus:install on v3.2
| @@ -88,12 +79,7 @@ fi | |||
|
|
|||
| unbundled bundle install --gemfile Gemfile | |||
| unbundled bin/rails db:drop db:create | |||
| unbundled bin/rails generate solidus:install \ | |||
| --auto-accept \ | |||
There was a problem hiding this comment.
I'm not super happy removing auto-accept by default, as it slows the development feedback. What do you think about keeping it?
There was a problem hiding this comment.
I think it's no big deal either way, easy to add or remove locally as needed, so I'll add it back (I had to remove it in order to test out the interactive solidus:install wizard).
| @@ -248,6 +274,13 @@ def complete | |||
| private | |||
|
|
|||
| def detect_frontend_to_install(bundler_context) | |||
| if options[:payment_method] != 'none' | |||
| say_status :warning, set_color( | |||
| "You selected a payment method that might require manual integration with `solidus_starter_frontend`", | |||
There was a problem hiding this comment.
I think a better experience would be warning before the payment has been selected.
There was a problem hiding this comment.
I'm fine with that, moving it
| # Solidus bolt will be handled in the installer as a payment method. | ||
| begin | ||
| skip_solidus_bolt = ENV['SKIP_SOLIDUS_BOLT'] | ||
| ENV['SKIP_SOLIDUS_BOLT'] = 'true' |
There was a problem hiding this comment.
If we move it here, I think we should remove the option from solidus_frontend altogether. Otherwise we're dealing with unneeded complexity here. WDYT?
There was a problem hiding this comment.
🎯 exactly, that's the idea, we can remove it as soon as v3.2 is updated
Just a generic warning, but we're trying to keep this minimal.
Since we don't have other ways to test solidus:install this allows providing any combination, including the interactive mode. Tangentially fix the missing newline escape before `$@`.
elia
force-pushed
the
elia/restore-payment-method-on-3-2
branch
from
84e1f91 to
4a99b8b
Compare
Without this only --with-authentication=false had an effect and the value of --payment-method was completely disregarded.
Forcefully skips its installation when installing solidus_frontend.
Otherwise installation checking for SolidusSupport.frontend_available? can fail.
elia
force-pushed
the
elia/restore-payment-method-on-3-2
branch
from
4a99b8b to
7c7e913
Compare
|
@jarednorman @waiting-for-dev I had to change a couple of things to check auth options for |
Summary
Solidus PCP is now compatible with Ruby 3 and can be re-enabled, since the CLI flag has been restored we can also attach bolt to it and let user select the payment method with CLI flags.
I included the minimum required to make the installer work, since we don't have tests for it I tried with:
and variations, also including the same options but interactively.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed (
cross them outif they are not):[ ] I have added automated tests to cover my changes.[ ] I have attached screenshots to demo visual changes.[ ] I have opened a PR to update the guides.[ ] I have updated the readme to account for my changes.