Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only support for Ruby v3 and Rails v7 #5012

Merged
merged 14 commits into from
Apr 24, 2023
Merged

Conversation

elia
Copy link
Member

@elia elia commented Apr 13, 2023

Summary

We're still committed to always have overlap between ruby/rails/solidus versions, and dropping Rails 6.x support is done with the perspective of Rails 7.1 being not so far away.

The CI looks yellow 🟡 just because we removed some jobs that used the older versions which are still required by branch rules, after merging the branch rules will be updated.

image

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia self-assigned this Apr 13, 2023
@github-actions github-actions bot added changelog:repository Changes to the repository not within any gem changelog:solidus_api Changes to the solidus_api gem changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem changelog:solidus_sample Changes to the solidus_sample gem changelog:solidus Changes to the solidus meta-gem labels Apr 13, 2023
@elia elia mentioned this pull request Apr 13, 2023
3 tasks
@elia elia added the release:major Breaking change on hold until next major release label Apr 13, 2023
@elia elia force-pushed the elia/drop-ruby-v2-7-support branch from 128054b to cf12ea1 Compare April 19, 2023 21:09
elia added a commit that referenced this pull request Apr 19, 2023
Bump the version of ruby used for testing the installer.

See also #5012
@elia elia force-pushed the elia/drop-ruby-v2-7-support branch 4 times, most recently from 64e8b6b to 9babd2f Compare April 19, 2023 21:52
@elia elia marked this pull request as ready for review April 19, 2023 22:22
@elia elia requested a review from a team as a code owner April 19, 2023 22:22
@elia elia changed the title Drop support for Ruby v2.7 and Rails v6.0 Only support for Ruby v3 and Rails v7 Apr 20, 2023
Copy link
Contributor

@waiting-for-dev waiting-for-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor comment! Thanks! ❤️

core/spec/lib/spree/bus_spec.rb Outdated Show resolved Hide resolved
elia added a commit that referenced this pull request Apr 21, 2023
Bump the version of ruby used for testing the installer.

See also #5012
@elia elia force-pushed the elia/drop-ruby-v2-7-support branch from 9babd2f to c1cff94 Compare April 24, 2023 09:30
@elia elia requested a review from waiting-for-dev April 24, 2023 09:31
@elia elia force-pushed the elia/drop-ruby-v2-7-support branch from c1cff94 to 77d21c9 Compare April 24, 2023 10:54
@elia elia mentioned this pull request Apr 24, 2023
3 tasks
Copy link
Contributor

@waiting-for-dev waiting-for-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking comment!

core/lib/spree/rails_compatibility.rb Outdated Show resolved Hide resolved
elia added 2 commits April 24, 2023 15:08
This example was set to be skipped 9 years ago, it's currently passing
so we'll just restore that.
@elia elia force-pushed the elia/drop-ruby-v2-7-support branch from 77d21c9 to 848e94e Compare April 24, 2023 13:22
@elia elia force-pushed the elia/drop-ruby-v2-7-support branch from 848e94e to 12026aa Compare April 24, 2023 13:43
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Eli!

@kennyadsl kennyadsl merged commit 9a05b22 into master Apr 24, 2023
@kennyadsl kennyadsl deleted the elia/drop-ruby-v2-7-support branch April 24, 2023 14:26
elia added a commit that referenced this pull request Apr 24, 2023
Bump the version of ruby used for testing the installer.

See also #5012
waiting-for-dev added a commit to solidusio/edgeguides that referenced this pull request Apr 25, 2023
That's what we have done in
solidusio/solidus#5012 for technical reasons.

We're also using "approach" instead of "policy" to avoid confusion with
our official policy, which doesn't mention this kind of support yet.

[1] - https://solidus.io/release_policy/
elia added a commit that referenced this pull request Apr 26, 2023
Bump the version of ruby used for testing the installer.

See also #5012
waiting-for-dev added a commit to solidusio/solidus_braintree that referenced this pull request May 2, 2023
Ruby v2.7 is no longer supported. Instead, v3.0 is the oldest version
[1].

[1] - solidusio/solidus#5012
waiting-for-dev added a commit to solidusio/solidus_braintree that referenced this pull request May 2, 2023
Ruby v2.7 reached EOL on 2023-03-31 [1].

This also fixes testing against Solidus master, which also dropped Ruby
2.7 support [2].

[1] - https://www.ruby-lang.org/en/downloads/branches/
[2] - solidusio/solidus#5012
waiting-for-dev added a commit to solidusio/solidus_paypal_commerce_platform that referenced this pull request May 2, 2023
Ruby v2.7 reached EOL on 2023-03-31 [1].

This also fixes testing against Solidus master, which also dropped Ruby
2.7 support [2].

[1] - https://www.ruby-lang.org/en/downloads/branches/
[2] - solidusio/solidus#5012
waiting-for-dev added a commit to solidusio/solidus_paypal_commerce_platform that referenced this pull request May 2, 2023
Ruby v2.7 reached EOL on 2023-03-31 [1].

This also fixes testing against Solidus master, which also dropped Ruby
2.7 support [2].

[1] - https://www.ruby-lang.org/en/downloads/branches/
[2] - solidusio/solidus#5012
kennyadsl pushed a commit to jakemumu/solidus_paypal_commerce_platform that referenced this pull request May 11, 2023
Ruby v2.7 reached EOL on 2023-03-31 [1].

This also fixes testing against Solidus master, which also dropped Ruby
2.7 support [2].

[1] - https://www.ruby-lang.org/en/downloads/branches/
[2] - solidusio/solidus#5012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:repository Changes to the repository not within any gem changelog:solidus_api Changes to the solidus_api gem changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem changelog:solidus_sample Changes to the solidus_sample gem changelog:solidus Changes to the solidus meta-gem release:major Breaking change on hold until next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluate removing support for Ruby/Rails versions close to EOL in 4.0
3 participants