-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only support for Ruby v3 and Rails v7 #5012
Conversation
128054b
to
cf12ea1
Compare
Bump the version of ruby used for testing the installer. See also #5012
64e8b6b
to
9babd2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a minor comment! Thanks! ❤️
Bump the version of ruby used for testing the installer. See also #5012
9babd2f
to
c1cff94
Compare
c1cff94
to
77d21c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking comment!
This example was set to be skipped 9 years ago, it's currently passing so we'll just restore that.
77d21c9
to
848e94e
Compare
848e94e
to
12026aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Eli!
Bump the version of ruby used for testing the installer. See also #5012
That's what we have done in solidusio/solidus#5012 for technical reasons. We're also using "approach" instead of "policy" to avoid confusion with our official policy, which doesn't mention this kind of support yet. [1] - https://solidus.io/release_policy/
Bump the version of ruby used for testing the installer. See also #5012
Ruby v2.7 is no longer supported. Instead, v3.0 is the oldest version [1]. [1] - solidusio/solidus#5012
Ruby v2.7 reached EOL on 2023-03-31 [1]. This also fixes testing against Solidus master, which also dropped Ruby 2.7 support [2]. [1] - https://www.ruby-lang.org/en/downloads/branches/ [2] - solidusio/solidus#5012
Ruby v2.7 reached EOL on 2023-03-31 [1]. This also fixes testing against Solidus master, which also dropped Ruby 2.7 support [2]. [1] - https://www.ruby-lang.org/en/downloads/branches/ [2] - solidusio/solidus#5012
Ruby v2.7 reached EOL on 2023-03-31 [1]. This also fixes testing against Solidus master, which also dropped Ruby 2.7 support [2]. [1] - https://www.ruby-lang.org/en/downloads/branches/ [2] - solidusio/solidus#5012
Ruby v2.7 reached EOL on 2023-03-31 [1]. This also fixes testing against Solidus master, which also dropped Ruby 2.7 support [2]. [1] - https://www.ruby-lang.org/en/downloads/branches/ [2] - solidusio/solidus#5012
Summary
stripe
to available payments in the solidus installer solidus_stripe#276We're still committed to always have overlap between ruby/rails/solidus versions, and dropping Rails 6.x support is done with the perspective of Rails 7.1 being not so far away.
The CI looks yellow 🟡 just because we removed some jobs that used the older versions which are still required by branch rules, after merging the branch rules will be updated.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: