Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generating the dummy app for extensions using solidus_frontend #5060

Merged
merged 1 commit into from
May 2, 2023
Merged

Fix generating the dummy app for extensions using solidus_frontend #5060

merged 1 commit into from
May 2, 2023

Conversation

waiting-for-dev
Copy link
Contributor

Summary

The dummy application uses the extension's Gemfile. If the extension is still relying on solidus_frontend, it'll already be present in its Gemfile. We don't need nor want adding it to the extension's Gemfile, but we do need to run its install generator.

Adding CI steps to cover it.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@waiting-for-dev
Fix generating the dummy app for extensions using solidus_frontend
aa336a6 
The dummy application uses the extension's Gemfile. If the extension is
still relying on solidus_frontend, it'll already be present in its
Gemfile. We don't need nor want adding it to the extension's Gemfile,
but we do need to run its install generator.

Adding CI steps to cover it.
@waiting-for-dev waiting-for-dev added type:bug Error, flaw or fault release:major Breaking change on hold until next major release labels Apr 28, 2023
@waiting-for-dev waiting-for-dev self-assigned this Apr 28, 2023
@waiting-for-dev waiting-for-dev requested a review from a team as a code owner April 28, 2023 15:30
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Apr 28, 2023
kennyadsl
kennyadsl approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

rainerdema
rainerdema approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@rainerdema rainerdema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@waiting-for-dev waiting-for-dev merged commit 7176bf6 into solidusio:master May 2, 2023
@waiting-for-dev waiting-for-dev deleted the waiting-for-dev/run_sf_gen_on_dummy branch May 2, 2023 03:47
@waiting-for-dev waiting-for-dev mentioned this pull request May 2, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainerdema rainerdema rainerdema approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

@elia elia elia approved these changes

Assignees

@waiting-for-dev waiting-for-dev

Labels
changelog:solidus_core Changes to the solidus_core gem release:major Breaking change on hold until next major release type:bug Error, flaw or fault
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@waiting-for-dev @elia @kennyadsl @rainerdema