Remove references to legacy :general_settings resource #5128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The resource was created in f83d9db (2015), but we stopped checking permissions on it in 60ea59a (2017), when we replaced it with checking on `Spree::Store`. Currently, the admin controller for `:general_settings` is only used to redirect to stores [1]. [1] - https://github.com/solidusio/solidus/blob/main/backend/app/controllers/spree/admin/general_settings_controller.rb
Instead, we can use `spree.store`. This is a leftover from 60ea59a (2017).
github-actions
bot
added
changelog:solidus_backend
3 tasks
rainerdema
approved these changes
Jun 7, 2023
elia
approved these changes
Jun 7, 2023
kennyadsl
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(Replaces #5127, closed by error)
The resource was created in f83d9db (2015), but we stopped checking permissions on it in 60ea59a (2017), when we replaced it with checking on
Spree::Store.Currently, the admin controller for
:general_settingsis only used to redirect to stores.We also remove the redundant admin locale key
spree.general_settings. Instead, we can usespree.store.Ref. #5102
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: