Allow running bin/rails from Solidus engines #5164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:repository
elia
force-pushed
the
elia/bin-rails-from-engines
branch
from
3b2514f to
1093c69
Compare
github-actions
bot
added
changelog:solidus_api
Generators and other tasks will behave differently if ran from an engine directory: - they'll use the engine namespaces - they'll write files to the engine dir With this change it will be possible to `bin/rails core g migration …` and have migrations or other generators work from the `core` folder. The `sandbox` app will still be the default.
elia
force-pushed
the
elia/bin-rails-from-engines
branch
from
1093c69 to
ea27756
Compare
Codecov Report
@@ Coverage Diff @@
## main #5164 +/- ##
=======================================
Coverage 88.66% 88.66%
=======================================
Files 563 563
Lines 13884 13884
=======================================
Hits 12310 12310
Misses 1574 1574 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
waiting-for-dev
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Generators and other tasks will behave differently if ran from an engine directory:
With this change it will be possible to
bin/rails core g migration …and have migrations or other generators work from thecorefolder.The
sandboxapp is still the default.This has been extracted from work on SolidusAdmin in which the component generator must be ran from the
admin/folder in order to create components in the engine vs. the sandbox.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: