Fix Taxon taxonomy id validation regression #5189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_core
RyanofWoods
changed the title
3 tasks
This optional validation for root taxons (parent_id is nil), was checking for uniqueness of taxonomy_id among all Taxons. This is wrong however, as the children Taxons of this root Taxon will point to the same Taxonomy. Instead, we should only look among other root Taxons.
RyanofWoods
force-pushed
the
ryanofwoods/fix-taxon-taxonomy_id-validation
branch
from
f99a549 to
b574c21
Compare
elia
approved these changes
Jun 28, 2023
kennyadsl
changed the title
kennyadsl
approved these changes
Jun 28, 2023
jarednorman
approved these changes
Jun 28, 2023
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5187.
In v3.4 I added optional Taxon validations which become mandatory in v4.0. This caused a regression which made all root taxons with children always invalid. This is a fix for v4, another PR for v3.4 was made:
#5190
This optional validation for root taxons (parent_id is nil), was
checking for uniqueness of taxonomy_id among all Taxons. This is wrong
however, as the children Taxons of this root Taxon will point to the
same Taxonomy. Instead, we should only look among other root Taxons.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: