-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[admin] Allow editing the order contact email #5500
Conversation
9decc64
to
e446a13
Compare
Codecov Report
@@ Coverage Diff @@
## main #5500 +/- ##
==========================================
+ Coverage 88.93% 88.95% +0.01%
==========================================
Files 622 624 +2
Lines 14918 14945 +27
==========================================
+ Hits 13268 13294 +26
- Misses 1650 1651 +1
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
19f4bea
to
3e89efa
Compare
the dialog title and controller name suggest that we update the user of the order (customer) but it only allows to change the email. are there any plans to add customer select as well or should we rename the controller and title to reflect that only the email gets changed? |
admin/app/components/solidus_admin/orders/show/customer/component.html.erb
Outdated
Show resolved
Hide resolved
3e89efa
to
8875493
Compare
8875493
to
1677f24
Compare
This way the natively show as inline.
Summary
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: