Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[admin] Add users index #5519

Merged
merged 3 commits into from
Nov 28, 2023
Merged

[admin] Add users index #5519

merged 3 commits into from
Nov 28, 2023

Conversation

elia
Copy link
Member

@elia elia commented Nov 27, 2023 •
edited
Loading

Summary

image

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia self-assigned this Nov 27, 2023
@elia elia force-pushed the elia/admin/users/index branch 2 times, most recently from 0f8d862 to f7fda53 Compare November 27, 2023 14:15
@elia elia force-pushed the elia/admin/users/index branch from f7fda53 to 8bc4c19 Compare November 27, 2023 14:22
@elia elia marked this pull request as ready for review November 27, 2023 14:36
@elia elia requested a review from a team as a code owner November 27, 2023 14:36
@elia elia force-pushed the elia/admin/users/index branch from 8bc4c19 to d53ab84 Compare November 27, 2023 14:36
@elia elia requested a review from rainerdema November 27, 2023 14:36
@elia elia force-pushed the elia/admin/users/index branch from d53ab84 to 2830c38 Compare November 27, 2023 14:41
rainerdema
rainerdema approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@rainerdema rainerdema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@elia elia merged commit 733eba1 into main Nov 28, 2023
8 checks passed
@elia elia deleted the elia/admin/users/index branch November 28, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainerdema rainerdema rainerdema approved these changes

Assignees

@elia elia

Labels
changelog:solidus_admin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elia @rainerdema